Integrate aethyr_setup with event sourcing initialization #158

Open
opened 2026-03-15 23:08:34 +00:00 by freemo · 0 comments
Owner

Metadata

  • Commit Message: feat(setup): integrate aethyr_setup storage initialization with event sourcing
  • Branch: feature/m1-setup-es-integration

Background and Context

bin/aethyr_setup option 2 (Initialize/reset storage) currently only initializes GDBM stores. It clears storage/passwords, storage/players, storage/goids GDBM files and recreates the world. It does not initialize the ES backend. Player deletion (option 3) and password changes (option 4) also only modify GDBM directly.

Current Behavior

Setup initializes only GDBM. ES is not touched during setup.

Expected Behavior

When ES is enabled, setup initializes ES alongside GDBM. Player operations route through both stores.

Acceptance Criteria

  • Storage reset initializes ES backend when enabled
  • Player deletion works through ES when enabled
  • Password changes work through ES when enabled
  • World generation objects stored in both GDBM and ES
  • Setup gracefully handles ImmuDB being unavailable

Subtasks

  • Add ES initialization in setup option 2 (reset storage)
  • Wire player deletion through ES in option 3
  • Wire password changes through ES in option 4
  • Add ImmuDB connectivity check with graceful fallback message
  • Tests (Cucumber): Scenario for setup with ES enabled
  • Run bundle exec rake unit, fix any failures
  • Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable.
  • Tests (Cucumber Integration): Add integration feature in tests/integration/ verifying aethyr_setup initializes event sourcing configuration correctly.
  • Tests (Profiling): Run bundle exec rake unit_profile and verify no performance regressions.
  • Quality: Verify coverage >=97% via bundle exec rake unit. If coverage is <97% then review the current unit test coverage report at build/tests/unit/coverage/ and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun bundle exec rake unit to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%.
  • Quality: Run bundle exec rake (default task: unit tests with coverage) and bundle exec rake integration, fix any errors if needed ensuring both pass across entire code base, do not ignore any failure even if it seems unrelated to this commit, fix it.

Definition of Done

This issue is complete when:

  • All subtasks above are completed and checked off.
  • A Git commit is created where the first line of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation.
  • The commit is pushed to the remote on the branch matching the Branch in Metadata exactly.
  • The commit is submitted as a pull request to master, reviewed, and merged before this issue is marked done.
## Metadata - **Commit Message:** `feat(setup): integrate aethyr_setup storage initialization with event sourcing` - **Branch:** `feature/m1-setup-es-integration` ## Background and Context `bin/aethyr_setup` option 2 (Initialize/reset storage) currently only initializes GDBM stores. It clears `storage/passwords`, `storage/players`, `storage/goids` GDBM files and recreates the world. It does not initialize the ES backend. Player deletion (option 3) and password changes (option 4) also only modify GDBM directly. ## Current Behavior Setup initializes only GDBM. ES is not touched during setup. ## Expected Behavior When ES is enabled, setup initializes ES alongside GDBM. Player operations route through both stores. ## Acceptance Criteria - Storage reset initializes ES backend when enabled - Player deletion works through ES when enabled - Password changes work through ES when enabled - World generation objects stored in both GDBM and ES - Setup gracefully handles ImmuDB being unavailable ## Subtasks - [ ] Add ES initialization in setup option 2 (reset storage) - [ ] Wire player deletion through ES in option 3 - [ ] Wire password changes through ES in option 4 - [ ] Add ImmuDB connectivity check with graceful fallback message - [ ] Tests (Cucumber): Scenario for setup with ES enabled - [ ] Run `bundle exec rake unit`, fix any failures - [ ] Docs: Update YARD comments on affected classes and methods. Update relevant Docusaurus documentation pages if applicable. - [ ] Tests (Cucumber Integration): Add integration feature in `tests/integration/` verifying aethyr_setup initializes event sourcing configuration correctly. - [ ] Tests (Profiling): Run `bundle exec rake unit_profile` and verify no performance regressions. - [ ] Quality: Verify coverage >=97% via `bundle exec rake unit`. If coverage is <97% then review the current unit test coverage report at `build/tests/unit/coverage/` and use it to write new Cucumber based unit tests to improve code coverage. Specifically, write Cucumber/Gherkin style unit tests that are descriptively named and specifically improve coverage on whichever file has the most uncovered lines by writing tests that will target the uncovered lines in the report. Once that is done rerun `bundle exec rake unit` to verify all tests pass and coverage is above >=97%. Only mark this as complete once coverage is >=97%, if not repeat this task as many times as is needed until coverage reaches >=97%. - [ ] Quality: Run `bundle exec rake` (default task: unit tests with coverage) and `bundle exec rake integration`, fix any errors if needed ensuring both pass across **entire** code base, do not ignore any failure even if it seems unrelated to this commit, fix it. ## Definition of Done This issue is complete when: - All subtasks above are completed and checked off. - A Git commit is created where the **first line** of the commit message matches the Commit Message in Metadata exactly, followed by a blank line, then additional lines providing relevant details about the implementation. - The commit is pushed to the remote on the branch matching the **Branch** in Metadata exactly. - The commit is submitted as a **pull request** to `master`, reviewed, and **merged** before this issue is marked done.
freemo added this to the v1.0.0 milestone 2026-03-15 23:19:42 +00:00
freemo self-assigned this 2026-03-16 01:27:09 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference: aethyr/Aethyr#158
No description provided.