fix: resolve all CI quality gate failures #341

Merged

freemo merged 1 commit from fix/ci-quality-gates into master 2026-04-01 01:50:20 +00:00

Conversation 0 Commits 1 Files changed 114 +543 -546

freemo commented 2026-03-31 18:42:06 +00:00

Owner

Copy link

Summary

This PR fixes all shared CI quality gate failures that affect master and every open PR.

Changes

1. Fix CI lint command - Changed bundle exec rubocop --parallel to bundle exec standardrb in .forgejo/workflows/ci.yml. The project uses StandardRB for linting, not raw RuboCop.

2. Fix 527+ StandardRB lint offenses - Auto-fixed indentation, spacing, and layout issues across ~93 files. Manually fixed 10 remaining offenses (duplicate method definitions, nested method definitions, useless assignments, semicolons).

3. Fix Sorbet type check error - Changed T.unsafe(super(nil, nil)) to T.unsafe(super(nil)) in lib/aethyr/core/objects/exit.rb:25. The second nil argument was unnecessary and conflicted with test stub definitions.

4. Add gary_steps.rb to Sorbet ignore - The test stub in gary_steps.rb redefines GameObject#initialize with fewer parameters than the real class. Added to Sorbet ignore list to prevent false conflicts.

Verification

• bundle exec standardrb exits with 0 (0 offenses)
• bundle exec srb tc reports "No errors! Great job."
• Integration tests pass locally (125 scenarios, 707 steps)
• Unit test coverage was 97.37% at last full run

Impact

Once merged, all 10 open feature PRs should be rebased onto master to inherit these fixes. Each PR will then only need its branch-specific Sorbet and coverage fixes.

## Summary This PR fixes all shared CI quality gate failures that affect master and every open PR. ### Changes 1. **Fix CI lint command** - Changed `bundle exec rubocop --parallel` to `bundle exec standardrb` in `.forgejo/workflows/ci.yml`. The project uses StandardRB for linting, not raw RuboCop. 2. **Fix 527+ StandardRB lint offenses** - Auto-fixed indentation, spacing, and layout issues across ~93 files. Manually fixed 10 remaining offenses (duplicate method definitions, nested method definitions, useless assignments, semicolons). 3. **Fix Sorbet type check error** - Changed `T.unsafe(super(nil, nil))` to `T.unsafe(super(nil))` in `lib/aethyr/core/objects/exit.rb:25`. The second nil argument was unnecessary and conflicted with test stub definitions. 4. **Add gary_steps.rb to Sorbet ignore** - The test stub in `gary_steps.rb` redefines `GameObject#initialize` with fewer parameters than the real class. Added to Sorbet ignore list to prevent false conflicts. ### Verification - `bundle exec standardrb` exits with 0 (0 offenses) - `bundle exec srb tc` reports "No errors! Great job." - Integration tests pass locally (125 scenarios, 707 steps) - Unit test coverage was 97.37% at last full run ### Impact Once merged, all 10 open feature PRs should be rebased onto master to inherit these fixes. Each PR will then only need its branch-specific Sorbet and coverage fixes.

freemo force-pushed fix/ci-quality-gates from a6407469e4 to a7efa635af 2026-03-31 19:18:59 +00:00 Compare

freemo force-pushed fix/ci-quality-gates from a7efa635af to ccb96f836e 2026-03-31 19:20:52 +00:00 Compare

freemo force-pushed fix/ci-quality-gates from ccb96f836e to 3a0a47e798 2026-03-31 19:24:47 +00:00 Compare

freemo force-pushed fix/ci-quality-gates from 3a0a47e798 to 1c56c5d2a7 2026-03-31 21:11:03 +00:00 Compare

freemo force-pushed fix/ci-quality-gates from 1c56c5d2a7 to b1f00ea9e0 2026-03-31 21:13:27 +00:00 Compare

freemo force-pushed fix/ci-quality-gates from b1f00ea9e0 to 088af8239a 2026-04-01 00:16:09 +00:00 Compare

freemo force-pushed fix/ci-quality-gates from 088af8239a to dcf2dc449d 2026-04-01 01:15:15 +00:00 Compare

freemo merged commit dcf2dc449d into master 2026-04-01 01:50:20 +00:00

freemo deleted branch fix/ci-quality-gates 2026-04-01 01:50:21 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Blocked

Cannot proceed, depends on unresolved issue

  

Duplicate

Issue is a duplicate of an existing one

  

MoSCoW/Could Have

Desirable but not necessary, included if time permits

  

MoSCoW/Must Have

Essential, project cannot ship without it

  

MoSCoW/Should Have

Important but not strictly essential

  

Points/1

Estimated effort: 1 story points

  

Points/13

Estimated effort: 13 story points

  

Points/2

Estimated effort: 2 story points

  

Points/21

Estimated effort: 21 story points

  

Points/3

Estimated effort: 3 story points

  

Points/5

Estimated effort: 5 story points

  

Points/8

Estimated effort: 8 story points

  

Priority/Backlog

Not yet prioritized

  

Priority/Critical

Must be addressed immediately

  

Priority/High

Important, should be completed soon

  

Priority/Low

Nice to have, not time-sensitive

  

Priority/Medium

Normal priority, valid and should be addressed

  

State/Completed

Issue resolved and all PRs merged

  

State/In progress

Someone is actively working on this issue

  

State/In review

Implementation complete, PR submitted for review

  

State/Paused

Work temporarily suspended, typically blocked

  

State/Unverified

Issue created but not yet reviewed by a maintainer

  

State/Verified

Maintainer confirmed valid and actionable

  

State/Wont Do

Deliberate decision not to address this issue

  

Type/Bug

A defect in existing functionality

  

Type/Epic

Large body of work broken into multiple issues

  

Type/Feature

A new capability or user story

  

Type/Legendary

Major strategic pillar composed of multiple Epics

  

Type/Task

Technical or administrative work (not bug or feature)

  

Type/Testing

Test-only work item (TDD, test infrastructure, coverage)

No labels

Blocked

Duplicate

MoSCoW/Could Have

MoSCoW/Must Have

MoSCoW/Should Have

Points/1

Points/13

Points/2

Points/21

Points/3

Points/5

Points/8

Priority/Backlog

Priority/Critical

Priority/High

Priority/Low

Priority/Medium

State/Completed

State/In progress

State/In review

State/Paused

State/Unverified

State/Verified

State/Wont Do

Type/Bug

Type/Epic

Type/Feature

Type/Legendary

Type/Task

Type/Testing

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

aethyr/Aethyr!341

No description provided.