fix: resolve all CI quality gate failures #341

Merged

freemo merged 1 commit from fix/ci-quality-gates into master

2026-04-01 01:50:20 +00:00

freemo commented

2026-03-31 18:42:06 +00:00

Owner

Summary

This PR fixes all shared CI quality gate failures that affect master and every open PR.

Changes

Fix CI lint command - Changed bundle exec rubocop --parallel to bundle exec standardrb in .forgejo/workflows/ci.yml. The project uses StandardRB for linting, not raw RuboCop.
Fix 527+ StandardRB lint offenses - Auto-fixed indentation, spacing, and layout issues across ~93 files. Manually fixed 10 remaining offenses (duplicate method definitions, nested method definitions, useless assignments, semicolons).
Fix Sorbet type check error - Changed T.unsafe(super(nil, nil)) to T.unsafe(super(nil)) in lib/aethyr/core/objects/exit.rb:25. The second nil argument was unnecessary and conflicted with test stub definitions.
Add gary_steps.rb to Sorbet ignore - The test stub in gary_steps.rb redefines GameObject#initialize with fewer parameters than the real class. Added to Sorbet ignore list to prevent false conflicts.

Verification

bundle exec standardrb exits with 0 (0 offenses)
bundle exec srb tc reports "No errors! Great job."
Integration tests pass locally (125 scenarios, 707 steps)
Unit test coverage was 97.37% at last full run

Impact

Once merged, all 10 open feature PRs should be rebased onto master to inherit these fixes. Each PR will then only need its branch-specific Sorbet and coverage fixes.

## Summary This PR fixes all shared CI quality gate failures that affect master and every open PR. ### Changes 1. **Fix CI lint command** - Changed `bundle exec rubocop --parallel` to `bundle exec standardrb` in `.forgejo/workflows/ci.yml`. The project uses StandardRB for linting, not raw RuboCop. 2. **Fix 527+ StandardRB lint offenses** - Auto-fixed indentation, spacing, and layout issues across ~93 files. Manually fixed 10 remaining offenses (duplicate method definitions, nested method definitions, useless assignments, semicolons). 3. **Fix Sorbet type check error** - Changed `T.unsafe(super(nil, nil))` to `T.unsafe(super(nil))` in `lib/aethyr/core/objects/exit.rb:25`. The second nil argument was unnecessary and conflicted with test stub definitions. 4. **Add gary_steps.rb to Sorbet ignore** - The test stub in `gary_steps.rb` redefines `GameObject#initialize` with fewer parameters than the real class. Added to Sorbet ignore list to prevent false conflicts. ### Verification - `bundle exec standardrb` exits with 0 (0 offenses) - `bundle exec srb tc` reports "No errors! Great job." - Integration tests pass locally (125 scenarios, 707 steps) - Unit test coverage was 97.37% at last full run ### Impact Once merged, all 10 open feature PRs should be rebased onto master to inherit these fixes. Each PR will then only need its branch-specific Sorbet and coverage fixes.

freemo added 1 commit

2026-03-31 18:42:07 +00:00

fix: resolve all CI quality gate failures

CI / integration_tests (pull_request) Failing after 23m43s

Details

CI / type_check (pull_request) Successful in 32m7s

Details

CI / build (pull_request) Has been skipped

Details

CI / lint (pull_request) Successful in 32m41s

Details

CI / unit_tests (pull_request) Failing after 52m3s

Details

a6407469e4

- Fix CI lint command: use standardrb instead of rubocop
- Auto-fix 527 StandardRB lint offenses (indentation, spacing)
- Fix 10 remaining lint issues (duplicate methods, nested defs, etc.)
- Fix Sorbet type error: exit.rb super(nil,nil) -> super(nil)
- Add gary_steps.rb to Sorbet ignore to prevent test stub conflicts

freemo force-pushed fix/ci-quality-gates from a6407469e4 to a7efa635af

2026-03-31 19:18:59 +00:00

Compare

freemo force-pushed fix/ci-quality-gates from a7efa635af to ccb96f836e

2026-03-31 19:20:52 +00:00

Compare

freemo force-pushed fix/ci-quality-gates from ccb96f836e to 3a0a47e798

2026-03-31 19:24:47 +00:00

Compare

freemo force-pushed fix/ci-quality-gates from 3a0a47e798 to 1c56c5d2a7

2026-03-31 21:11:03 +00:00

Compare