aethyr/Aethyr
2
0
Fork 0
Code Issues 281 Pull requests Projects Releases Packages Wiki Activity Actions

feat(lifecycle): add HookEvent and LifecycleHooks registry #340

Merged
freemo merged 2 commits from feature/m1-lifecycle-hooks into master 2026-04-01 01:52:55 +00:00
Conversation 0 Commits 2 Files changed 4 +477
freemo commented 2026-03-31 05:46:46 +00:00
Owner
Copy link

Summary

Closes #83

Implements the foundational lifecycle hooks system for the Aethyr MUD framework:

  • HookEvent — Immutable data class carrying type (Symbol), source (Object), data (Hash), and cancelled (Boolean) fields. Both the event object and its data hash are frozen on creation.

  • LifecycleHooks — Singleton registry module providing thread-safe on/once/off/emit methods with Mutex-protected callback storage. Callbacks fire in registration order; one-shot callbacks auto-remove after first invocation.

Changes

File Description
lib/aethyr/core/components/lifecycle/hook_event.rb HookEvent immutable data class
lib/aethyr/core/components/lifecycle/lifecycle_hooks.rb LifecycleHooks registry with on/once/off/emit
tests/unit/lifecycle_hooks.feature 20 BDD scenarios covering all acceptance criteria
tests/unit/step_definitions/lifecycle_hooks_steps.rb Step definitions with custom :symbol ParameterType

Testing

  • 20 scenarios, 64 steps — all passing
  • Covers: registration, emission, one-shot callbacks, removal, immutability, argument validation, registration order, and return values
  • Rubocop: 0 offenses on all new files
  • Thread-safety via Mutex-protected callback storage
## Summary Closes #83 Implements the foundational lifecycle hooks system for the Aethyr MUD framework: - **`HookEvent`** — Immutable data class carrying `type` (Symbol), `source` (Object), `data` (Hash), and `cancelled` (Boolean) fields. Both the event object and its data hash are frozen on creation. - **`LifecycleHooks`** — Singleton registry module providing thread-safe `on`/`once`/`off`/`emit` methods with Mutex-protected callback storage. Callbacks fire in registration order; one-shot callbacks auto-remove after first invocation. ## Changes | File | Description | |------|-------------| | `lib/aethyr/core/components/lifecycle/hook_event.rb` | HookEvent immutable data class | | `lib/aethyr/core/components/lifecycle/lifecycle_hooks.rb` | LifecycleHooks registry with on/once/off/emit | | `tests/unit/lifecycle_hooks.feature` | 20 BDD scenarios covering all acceptance criteria | | `tests/unit/step_definitions/lifecycle_hooks_steps.rb` | Step definitions with custom `:symbol` ParameterType | ## Testing - 20 scenarios, 64 steps — all passing - Covers: registration, emission, one-shot callbacks, removal, immutability, argument validation, registration order, and return values - Rubocop: 0 offenses on all new files - Thread-safety via Mutex-protected callback storage
freemo added this to the v1.0.0 milestone 2026-03-31 05:46:46 +00:00
feat(lifecycle): add HookEvent and LifecycleHooks registry
Some checks failed
CI / type_check (pull_request) Failing after 20m36s
Details
CI / lint (pull_request) Failing after 20m43s
Details
CI / unit_tests (pull_request) Failing after 20m46s
Details
CI / build (pull_request) Has been skipped
Details
CI / integration_tests (pull_request) Failing after 3m56s
Details
231ed62582 
Implemented the HookEvent immutable data class with type, source, data, and
cancelled fields, and the LifecycleHooks singleton registry with thread-safe
on/once/off/emit methods using Mutex-protected callback storage. Added
comprehensive Cucumber BDD scenarios covering registration, emission,
one-shot callbacks, removal, immutability, and argument validation.

ISSUES CLOSED: #83
freemo force-pushed feature/m1-lifecycle-hooks from 231ed62582 to d4ad67752c 2026-03-31 18:45:03 +00:00 Compare
freemo force-pushed feature/m1-lifecycle-hooks from d4ad67752c to f33982665e 2026-03-31 19:21:33 +00:00 Compare
freemo force-pushed feature/m1-lifecycle-hooks from f33982665e to 6270741a38 2026-03-31 21:13:38 +00:00 Compare
freemo force-pushed feature/m1-lifecycle-hooks from 6270741a38 to 9a52108ea1 2026-04-01 00:54:13 +00:00 Compare
freemo force-pushed feature/m1-lifecycle-hooks from 9a52108ea1 to b570dbe54d 2026-04-01 01:16:58 +00:00 Compare
freemo force-pushed feature/m1-lifecycle-hooks from b570dbe54d to 9b3d7e1cf1 2026-04-01 01:25:11 +00:00 Compare
freemo merged commit 77041274d8 into master 2026-04-01 01:52:55 +00:00
freemo deleted branch feature/m1-lifecycle-hooks 2026-04-01 01:52:56 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Blocked

Cannot proceed, depends on unresolved issue

  
Duplicate

Issue is a duplicate of an existing one

  
MoSCoW/Could Have

Desirable but not necessary, included if time permits

  
MoSCoW/Must Have

Essential, project cannot ship without it

  
MoSCoW/Should Have

Important but not strictly essential

  
Points/1

Estimated effort: 1 story points

  
Points/13

Estimated effort: 13 story points

  
Points/2

Estimated effort: 2 story points

  
Points/21

Estimated effort: 21 story points

  
Points/3

Estimated effort: 3 story points

  
Points/5

Estimated effort: 5 story points

  
Points/8

Estimated effort: 8 story points

  
Priority/Backlog

Not yet prioritized

  
Priority/Critical

Must be addressed immediately

  
Priority/High

Important, should be completed soon

  
Priority/Low

Nice to have, not time-sensitive

  
Priority/Medium

Normal priority, valid and should be addressed

  
State/Completed

Issue resolved and all PRs merged

  
State/In progress

Someone is actively working on this issue

  
State/In review

Implementation complete, PR submitted for review

  
State/Paused

Work temporarily suspended, typically blocked

  
State/Unverified

Issue created but not yet reviewed by a maintainer

  
State/Verified

Maintainer confirmed valid and actionable

  
State/Wont Do

Deliberate decision not to address this issue

  
Type/Bug

A defect in existing functionality

  
Type/Epic

Large body of work broken into multiple issues

  
Type/Feature

A new capability or user story

  
Type/Legendary

Major strategic pillar composed of multiple Epics

  
Type/Task

Technical or administrative work (not bug or feature)

  
Type/Testing

Test-only work item (TDD, test infrastructure, coverage)

No labels
Blocked
Duplicate
MoSCoW/Could Have
MoSCoW/Must Have
MoSCoW/Should Have
Points/1
Points/13
Points/2
Points/21
Points/3
Points/5
Points/8
Priority/Backlog
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
State/Completed
State/In progress
State/In review
State/Paused
State/Unverified
State/Verified
State/Wont Do
Type/Bug
Type/Epic
Type/Feature
Type/Legendary
Type/Task
Type/Testing
Milestone
Clear milestone
No items
No milestone
v1.0.0
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: aethyr/Aethyr#340
No description provided.
Delete branch "feature/m1-lifecycle-hooks"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?