feat(dispatch): implement Middleware base and pipeline executor #338

Merged

freemo merged 3 commits from feature/m1-middleware-pipeline into master 2026-04-01 01:52:12 +00:00

Conversation 0 Commits 3 Files changed 4 +638

freemo commented 2026-03-31 05:32:28 +00:00

Owner

Copy link

Summary

• Implemented Middleware base class (lib/aethyr/core/commands/middleware.rb) with priority ordering (default 500), phase designation (:before_action/:after_action), call(action, context) interface, and class-level register method
• Implemented MiddlewarePipeline executor (lib/aethyr/core/commands/middleware_pipeline.rb) with Mutex-protected registry, priority-sorted before/after phases, and throw(:halt) chain interruption mechanism
• Added 19 Cucumber BDD scenarios covering execution order, halt behavior, argument validation, context passing, class-level registration, and edge cases

Closes #105

Implementation Details

• Thread-safe: Registry is protected by a Mutex; snapshot_middleware extracts before/after lists under the lock, then execution proceeds without holding the lock
• Immutable defaults: VALID_PHASES is frozen; priority and phase are set at construction time
• Argument validation: All public methods validate types per CONTRIBUTING.md (nil checks, type verification, value range for phases)
• Sorbet typed: Both source files use # typed: strict with full sig annotations
• RuboCop clean: 0 offenses on all new files
• Full BDD coverage: 19 scenarios, 74 steps, all passing

## Summary - Implemented `Middleware` base class (`lib/aethyr/core/commands/middleware.rb`) with priority ordering (default 500), phase designation (:before_action/:after_action), `call(action, context)` interface, and class-level `register` method - Implemented `MiddlewarePipeline` executor (`lib/aethyr/core/commands/middleware_pipeline.rb`) with Mutex-protected registry, priority-sorted before/after phases, and `throw(:halt)` chain interruption mechanism - Added 19 Cucumber BDD scenarios covering execution order, halt behavior, argument validation, context passing, class-level registration, and edge cases Closes #105 ## Implementation Details - **Thread-safe**: Registry is protected by a Mutex; `snapshot_middleware` extracts before/after lists under the lock, then execution proceeds without holding the lock - **Immutable defaults**: `VALID_PHASES` is frozen; priority and phase are set at construction time - **Argument validation**: All public methods validate types per CONTRIBUTING.md (nil checks, type verification, value range for phases) - **Sorbet typed**: Both source files use `# typed: strict` with full `sig` annotations - **RuboCop clean**: 0 offenses on all new files - **Full BDD coverage**: 19 scenarios, 74 steps, all passing

freemo added this to the v1.0.0 milestone 2026-03-31 05:32:28 +00:00

freemo added the

Type/Feature

label 2026-03-31 05:32:28 +00:00

freemo added a new dependency 2026-03-31 05:33:27 +00:00

#105 Implement Middleware base class and MiddlewarePipeline executor with priority ordering

freemo force-pushed feature/m1-middleware-pipeline from 43b7997e5d to 00137d6e3d 2026-03-31 19:24:40 +00:00 Compare

freemo force-pushed feature/m1-middleware-pipeline from 00137d6e3d to b71a2d7348 2026-03-31 21:13:39 +00:00 Compare

freemo force-pushed feature/m1-middleware-pipeline from b71a2d7348 to c227b71c3b 2026-04-01 00:18:19 +00:00 Compare

freemo force-pushed feature/m1-middleware-pipeline from c227b71c3b to bfc3984dc9 2026-04-01 01:18:04 +00:00 Compare

freemo merged commit a1df8d4580 into master 2026-04-01 01:52:12 +00:00

freemo deleted branch feature/m1-middleware-pipeline 2026-04-01 01:52:12 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

Blocked

Cannot proceed, depends on unresolved issue

  

Duplicate

Issue is a duplicate of an existing one

  

MoSCoW/Could Have

Desirable but not necessary, included if time permits

  

MoSCoW/Must Have

Essential, project cannot ship without it

  

MoSCoW/Should Have

Important but not strictly essential

  

Points/1

Estimated effort: 1 story points

  

Points/13

Estimated effort: 13 story points

  

Points/2

Estimated effort: 2 story points

  

Points/21

Estimated effort: 21 story points

  

Points/3

Estimated effort: 3 story points

  

Points/5

Estimated effort: 5 story points

  

Points/8

Estimated effort: 8 story points

  

Priority/Backlog

Not yet prioritized

  

Priority/Critical

Must be addressed immediately

  

Priority/High

Important, should be completed soon

  

Priority/Low

Nice to have, not time-sensitive

  

Priority/Medium

Normal priority, valid and should be addressed

  

State/Completed

Issue resolved and all PRs merged

  

State/In progress

Someone is actively working on this issue

  

State/In review

Implementation complete, PR submitted for review

  

State/Paused

Work temporarily suspended, typically blocked

  

State/Unverified

Issue created but not yet reviewed by a maintainer

  

State/Verified

Maintainer confirmed valid and actionable

  

State/Wont Do

Deliberate decision not to address this issue

  

Type/Bug

A defect in existing functionality

  

Type/Epic

Large body of work broken into multiple issues

  

Type/Feature

A new capability or user story

  

Type/Legendary

Major strategic pillar composed of multiple Epics

  

Type/Task

Technical or administrative work (not bug or feature)

  

Type/Testing

Test-only work item (TDD, test infrastructure, coverage)

No labels

Blocked

Duplicate

MoSCoW/Could Have

MoSCoW/Must Have

MoSCoW/Should Have

Points/1

Points/13

Points/2

Points/21

Points/3

Points/5

Points/8

Priority/Backlog

Priority/Critical

Priority/High

Priority/Low

Priority/Medium

State/Completed

State/In progress

State/In review

State/Paused

State/Unverified

State/Verified

State/Wont Do

Type/Bug

Type/Epic

Type/Feature

Type/Legendary

Type/Task

Type/Testing

Milestone

Clear milestone

No items

No milestone

v1.0.0

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Blocks

#105 Implement Middleware base class and MiddlewarePipeline executor with priority ordering

aethyr/Aethyr

Reference

aethyr/Aethyr!338

No description provided.