feat: implement auto-resubscription on room changes and combat transitions #326

Merged

freemo merged 1 commit from feature/m2-ui-resubscribe into master

2026-03-16 20:09:45 +00:00

freemo commented

2026-03-16 16:36:35 +00:00

Owner

Summary

Enhances UIEventSubscriber to automatically manage subscriptions when player context changes
Implements room change detection with automatic area resubscription when moving to a different area
Implements combat start/end lifecycle hooks for automatic CombatInstance subscription management

Changes

UIEventSubscriber: Added lifecycle hook registration for room_changed, combat_started, combat_ended events
Auto-resubscription handlers: on_room_changed, on_combat_started, on_combat_ended methods
Duplicate subscription guards: Prevents subscribing to the same object twice
New accessors: current_room, current_area, current_combat, lifecycle_hooks_registered?

Testing

23 unit test scenarios in tests/unit/ui_resubscribe.feature
6 integration test scenarios in tests/integration/ui_resubscribe_integration.feature
All existing UIEventSubscriber tests pass (45 scenarios total)

Closes

Closes #300

## Summary - Enhances UIEventSubscriber to automatically manage subscriptions when player context changes - Implements room change detection with automatic area resubscription when moving to a different area - Implements combat start/end lifecycle hooks for automatic CombatInstance subscription management ## Changes - **UIEventSubscriber**: Added lifecycle hook registration for `room_changed`, `combat_started`, `combat_ended` events - **Auto-resubscription handlers**: `on_room_changed`, `on_combat_started`, `on_combat_ended` methods - **Duplicate subscription guards**: Prevents subscribing to the same object twice - **New accessors**: `current_room`, `current_area`, `current_combat`, `lifecycle_hooks_registered?` ## Testing - 23 unit test scenarios in `tests/unit/ui_resubscribe.feature` - 6 integration test scenarios in `tests/integration/ui_resubscribe_integration.feature` - All existing UIEventSubscriber tests pass (45 scenarios total) ## Closes Closes #300

freemo added 1 commit

2026-03-16 16:36:35 +00:00

feat: implement RenderOp data model and core RenderOp types 4edb789734

Implements the RenderOp value object class for the UI render pipeline as
specified in issue #304. RenderOps are immutable value objects that describe
rendering instructions without specifying how they should be rendered.

Key features:
- Immutable value objects (frozen after creation) with type, window, and data
- Seven core RenderOp types: text_append, map_refresh, bar_update,
  prompt_update, window_clear, overlay_show, overlay_hide
- Factory methods for convenient construction: RenderOp.text_append(),
  RenderOp.bar_update(), etc.
- Data validation per type (required fields are enforced)
- Equality comparison support (== and hash for use as hash keys)
- to_h serialization for logging and debugging
- Comprehensive YARD documentation

Testing:
- 36 Cucumber scenarios covering all factory methods, immutability,
  validation, equality, and type constants
- 3 integration scenarios for realistic usage patterns

ISSUES CLOSED: #304