aethyr/Aethyr
2
0
Fork 0
Code Issues 281 Pull requests Projects Releases Packages Wiki Activity Actions

feat: implement DirectionValidator and PlayerOnlineValidator #323

Merged
freemo merged 5 commits from feature/m1-direction-validator into master 2026-03-16 19:55:53 +00:00
Conversation 0 Commits 5 Files changed 6 +651
freemo commented 2026-03-16 16:09:34 +00:00
Owner
Copy link

Summary

  • Implement DirectionValidator for validating and normalizing direction strings
  • Implement PlayerOnlineValidator for validating online player names
  • Add comprehensive Cucumber test coverage for both validators

Changes

DirectionValidator

  • Validates 12 short-form directions: n, s, e, w, u, d, ne, nw, se, sw, in, out
  • Normalizes 10 long-form aliases to short-form (north->n, etc.)
  • Case-insensitive input handling
  • Returns Result struct with value or error

PlayerOnlineValidator

  • Case-insensitive player name lookup
  • Returns Player object on success
  • Handles edge cases (empty names, missing manager)
  • Returns descriptive error messages

Tests

  • 31 scenarios for DirectionValidator
  • 13 scenarios for PlayerOnlineValidator
  • All tests passing

Closes #295

## Summary - Implement DirectionValidator for validating and normalizing direction strings - Implement PlayerOnlineValidator for validating online player names - Add comprehensive Cucumber test coverage for both validators ## Changes ### DirectionValidator - Validates 12 short-form directions: n, s, e, w, u, d, ne, nw, se, sw, in, out - Normalizes 10 long-form aliases to short-form (north->n, etc.) - Case-insensitive input handling - Returns Result struct with value or error ### PlayerOnlineValidator - Case-insensitive player name lookup - Returns Player object on success - Handles edge cases (empty names, missing manager) - Returns descriptive error messages ### Tests - 31 scenarios for DirectionValidator - 13 scenarios for PlayerOnlineValidator - All tests passing Closes #295
freemo force-pushed feature/m1-direction-validator from 324a40ba8d to 15a2e028a2 2026-03-16 16:57:37 +00:00 Compare
freemo changed target branch from feature/m1-validation-pipeline to master 2026-03-16 16:57:43 +00:00
freemo force-pushed feature/m1-direction-validator from 15a2e028a2 to 7c85d42ab6 2026-03-16 17:07:31 +00:00 Compare
freemo force-pushed feature/m1-direction-validator from 7c85d42ab6 to 18033ebefe 2026-03-16 17:32:24 +00:00 Compare
freemo force-pushed feature/m1-direction-validator from 18033ebefe to 88f06c481f 2026-03-16 19:55:45 +00:00 Compare
freemo merged commit 88f06c481f into master 2026-03-16 19:55:53 +00:00
freemo deleted branch feature/m1-direction-validator 2026-03-16 19:55:54 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
Blocked

Cannot proceed, depends on unresolved issue

  
Duplicate

Issue is a duplicate of an existing one

  
MoSCoW/Could Have

Desirable but not necessary, included if time permits

  
MoSCoW/Must Have

Essential, project cannot ship without it

  
MoSCoW/Should Have

Important but not strictly essential

  
Points/1

Estimated effort: 1 story points

  
Points/13

Estimated effort: 13 story points

  
Points/2

Estimated effort: 2 story points

  
Points/21

Estimated effort: 21 story points

  
Points/3

Estimated effort: 3 story points

  
Points/5

Estimated effort: 5 story points

  
Points/8

Estimated effort: 8 story points

  
Priority/Backlog

Not yet prioritized

  
Priority/Critical

Must be addressed immediately

  
Priority/High

Important, should be completed soon

  
Priority/Low

Nice to have, not time-sensitive

  
Priority/Medium

Normal priority, valid and should be addressed

  
State/Completed

Issue resolved and all PRs merged

  
State/In progress

Someone is actively working on this issue

  
State/In review

Implementation complete, PR submitted for review

  
State/Paused

Work temporarily suspended, typically blocked

  
State/Unverified

Issue created but not yet reviewed by a maintainer

  
State/Verified

Maintainer confirmed valid and actionable

  
State/Wont Do

Deliberate decision not to address this issue

  
Type/Bug

A defect in existing functionality

  
Type/Epic

Large body of work broken into multiple issues

  
Type/Feature

A new capability or user story

  
Type/Legendary

Major strategic pillar composed of multiple Epics

  
Type/Task

Technical or administrative work (not bug or feature)

  
Type/Testing

Test-only work item (TDD, test infrastructure, coverage)

No labels
Blocked
Duplicate
MoSCoW/Could Have
MoSCoW/Must Have
MoSCoW/Should Have
Points/1
Points/13
Points/2
Points/21
Points/3
Points/5
Points/8
Priority/Backlog
Priority/Critical
Priority/High
Priority/Low
Priority/Medium
State/Completed
State/In progress
State/In review
State/Paused
State/Unverified
State/Verified
State/Wont Do
Type/Bug
Type/Epic
Type/Feature
Type/Legendary
Type/Task
Type/Testing
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: aethyr/Aethyr#323
No description provided.
Delete branch "feature/m1-direction-validator"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?